lkml.org 
[lkml]   [2010]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RFC] tun: add ioctl to modify vnet header size
From
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 18 Mar 2010 00:11:17 +0200

> All this does is set how much of the buffer to skip, this option does
> not allocate any memory. So if you set it to a value > length that you
> passed in, you get -EINVAL. Anything else should work. Negative values
> are checked for and return -EINVAL when you try to set it. At least,
> all that's by design - pls take a look at the code and if you see any
> issues, speak up please.
>
> I agree we don't really need to support very large values here,
> it just seemed less work.

This all looks fine to me, submit a final version to me via
whatever means you feel is appropriate.


\
 
 \ /
  Last update: 2010-03-22 04:19    [W:0.058 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site