lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 19/24] staging/dream: fix dangling pointers
    Fix I2C-drivers which missed setting clientdata to NULL before freeing the
    structure it points to. Also fix drivers which do this _after_ the structure
    was freed already.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    ---

    Found using coccinelle, then reviewed. Full patchset is available via
    kernel-janitors, linux-i2c, and LKML.
    ---
    drivers/staging/dream/synaptics_i2c_rmi.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
    index 4de6bc9..a318c18 100644
    --- a/drivers/staging/dream/synaptics_i2c_rmi.c
    +++ b/drivers/staging/dream/synaptics_i2c_rmi.c
    @@ -534,6 +534,7 @@ err_input_register_device_failed:
    err_input_dev_alloc_failed:
    err_detect_failed:
    err_power_failed:
    + i2c_set_clientdata(client, NULL);
    kfree(ts);
    err_alloc_data_failed:
    err_check_functionality_failed:
    @@ -551,6 +552,7 @@ static int synaptics_ts_remove(struct i2c_client *client)
    else
    hrtimer_cancel(&ts->timer);
    input_unregister_device(ts->input_dev);
    + i2c_set_clientdata(client, NULL);
    kfree(ts);
    return 0;
    }
    --
    1.7.0


    \
     
     \ /
      Last update: 2010-03-20 15:19    [W:0.020 / U:121.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site