lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 16/24] power: fix dangling pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---

Found using coccinelle, then reviewed. Full patchset is available via
kernel-janitors, linux-i2c, and LKML.
---
drivers/power/bq27x00_battery.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
index bece33e..b909103 100644
--- a/drivers/power/bq27x00_battery.c
+++ b/drivers/power/bq27x00_battery.c
@@ -399,6 +399,7 @@ static int bq27x00_battery_probe(struct i2c_client *client,

batt_failed_4:
kfree(bus);
+ i2c_set_clientdata(client, NULL);
batt_failed_3:
kfree(di);
batt_failed_2:
@@ -423,6 +424,7 @@ static int bq27x00_battery_remove(struct i2c_client *client)
idr_remove(&battery_id, di->id);
mutex_unlock(&battery_mutex);

+ i2c_set_clientdata(client, NULL);
kfree(di);

return 0;
--
1.7.0


\
 
 \ /
  Last update: 2010-03-20 15:19    [W:0.250 / U:11.280 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site