lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device
On Sat, Mar 20, 2010 at 05:04:15PM +0100, Bruno Prémont wrote:
> +static inline int picolcd_fb_send_tile(struct hid_device *hdev, int chip,
> + int tile)
> +{

You seemt o be fond of the 'inline; attribute ;) I don't think that a
40 lines function qualifies. Please lose inlines on functions that are
not in .h files and are not stubs.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-03-21 04:29    [from the cache]
©2003-2011 Jasper Spaans