lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/36] serial: Char: cyclades, fix compiler warning
    Date
    From: Jiri Slaby <jslaby@novell.com>

    With gcc 4.0.2:
    drivers/char/cyclades.c: In function 'cyy_interrupt':
    drivers/char/cyclades.c:581: warning: 'info' may be used uninitialized in this function

    introduced by

    : commit 3aeea5b92210083c7cffd4f08a0bb141d3f2d574
    : Author: Jiri Slaby <jirislaby@gmail.com>
    : AuthorDate: Sat Sep 19 13:13:16 2009 -0700
    : Commit: Live-CD User <linux@linux.site>
    : CommitDate: Sat Sep 19 13:13:16 2009 -0700
    :
    : cyclades: introduce cyy_readb/writeb

    In fact the true branch which uses uninitialized 'info' can never
    happen because chip is always less than ->nchips and channel is
    always less than 4 which we alloc.

    So behave similar to rx handling and remove the test completely.

    I wonder why gcc 4.4.1 doesn't spit a word.

    Reported-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Jiri Slaby <jslaby@novell.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/char/cyclades.c | 6 ------
    1 files changed, 0 insertions(+), 6 deletions(-)

    diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
    index 4254457..274e965 100644
    --- a/drivers/char/cyclades.c
    +++ b/drivers/char/cyclades.c
    @@ -598,12 +598,6 @@ static void cyy_chip_tx(struct cyclades_card *cinfo, unsigned int chip,
    save_car = readb(base_addr + (CyCAR << index));
    cy_writeb(base_addr + (CyCAR << index), save_xir);

    - /* validate the port# (as configured and open) */
    - if (channel + chip * 4 >= cinfo->nports) {
    - cy_writeb(base_addr + (CySRER << index),
    - readb(base_addr + (CySRER << index)) & ~CyTxRdy);
    - goto end;
    - }
    info = &cinfo->ports[channel + chip * 4];
    tty = tty_port_tty_get(&info->port);
    if (tty == NULL) {
    --
    1.7.0.1


    \
     
     \ /
      Last update: 2010-03-03 00:55    [W:0.019 / U:64.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site