lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ACPI, APEI, PCIE AER, use general HEST table parsing in AER firmware_first setup
(2010/03/02 10:55), Huang Ying wrote:
> ... The firmware_first setup code is moved from PCI core to
> AER driver too, because it is only AER related.
(snip)
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
> index c843a79..cc527c1 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -858,6 +858,8 @@ void aer_delete_rootport(struct aer_rpc *rpc)
> */
> int aer_init(struct pcie_device *dev)
> {
> + aer_set_firmware_first(dev);
> +
> if (dev->port->aer_firmware_first) {
> dev_printk(KERN_DEBUG, &dev->device,
> "PCIe errors handled by platform firmware.\n");
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2a94309..ccfaf19 100644
(snip)
> @@ -935,7 +928,6 @@ int pci_setup_device(struct pci_dev *dev)
> dev->multifunction = !!(hdr_type & 0x80);
> dev->error_state = pci_channel_io_normal;
> set_pcie_port_type(dev);
> - set_pci_aer_firmware_first(dev);
>
> list_for_each_entry(slot, &dev->bus->slots, list)
> if (PCI_SLOT(dev->devfn) == slot->number)

The aer_init() will be called for root ports, but not for end point
devices or so on. So please remain the firmware_first setup code in
PCI core. Otherwise endpoint drivers will get success on call of
pci_enable_pcie_error_reporting() regardless of the firmware first.


Thanks,
H.Seto



\
 
 \ /
  Last update: 2010-03-02 09:13    [from the cache]
©2003-2011 Jasper Spaans