lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/36] serial: bfin_5xx: kgdboc should accept gdb break only when it is active
    Date
    From: Sonic Zhang <sonic.zhang@analog.com>

    If we always check for gdb breaks even when it isn't active, we get false
    positives on normal code and the system panics.

    URL: http://blackfin.uclinux.org/gf/tracker/5277

    Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/serial/bfin_5xx.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
    index b5a9b37..6b87955 100644
    --- a/drivers/serial/bfin_5xx.c
    +++ b/drivers/serial/bfin_5xx.c
    @@ -237,7 +237,8 @@ static void bfin_serial_rx_chars(struct bfin_serial_port *uart)

    #if defined(CONFIG_KGDB_SERIAL_CONSOLE) || \
    defined(CONFIG_KGDB_SERIAL_CONSOLE_MODULE)
    - if (kgdb_connected && kgdboc_port_line == uart->port.line)
    + if (kgdb_connected && kgdboc_port_line == uart->port.line
    + && kgdboc_break_enabled)
    if (ch == 0x3) {/* Ctrl + C */
    kgdb_breakpoint();
    return;
    --
    1.7.0.1


    \
     
     \ /
      Last update: 2010-03-03 00:41    [W:0.019 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site