lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[RFC][PATCH 0/2] Correct behavior for listxattr and 'trusted' xattrs
    I noticed that there are differences in the behavior of listxattr(2) for 
    xattrs in the trusted namespace.

    Some filesystems, such as ext[234], require CAP_SYS_ADMIN for this, i.e.
    trusted xattr names are hidden from unprivileged users.

    I audited the kernel for users of the trusted xattr namespace, and found
    the following filesystems not checking for CAP_SYS_ADMIN:

    - jffs2
    - ocfs2
    - btrfs
    - xfs

    I've created patches for jffs2 (tested) and ocfs2 (not tested) to add the
    check -- see following emails. btrfs and xfs have custom listxattr
    operations and will need a bit more work to fix.

    I'm not sure what the initial intention was for the behavior, although
    given that several major filesystems are have been fielded with the
    CAP_SYS_ADMIN check, it seems most prudent to make this the standard
    behavior for all filesystems, in case any users are depending on it.

    Thoughts?


    - James
    --
    James Morris
    <jmorris@namei.org>


    \
     
     \ /
      Last update: 2010-03-02 09:03    [W:2.469 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site