lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] rfkill bug fixed in rfkill_set_sw_state
Suitable cc's (from scripts/get_maintainer.pl) added.

On Fri, 26 Feb 2010 13:55:31 +0900
_________ <jh80.chung@samsung.com> wrote:

> Don___t work expected operation in __rfkill_set_sw_state.
> when rfkill initialized. Rfkill___s blocked & unblocked is operating on the
> contrary.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> ---
> net/rfkill/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index c224cb2..dcc2d38 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -488,7 +488,7 @@ static void __rfkill_set_sw_state(struct rfkill
> *rfkill, bool blocked)
> if (rfkill->state & RFKILL_BLOCK_SW_SETCALL)
> bit = RFKILL_BLOCK_SW_PREV;
>
> - if (blocked)
> + if (!blocked)
> rfkill->state |= bit;
> else
> rfkill->state &= ~bit;

Are you sure? What problems were you observing with the existing code?
Please fully describe your hardware and the driver's behaviour.

The current code _looks_ OK to me. If bool `blocked' is true, we set
the RFKILL_BLOCK_SW bit?



\
 
 \ /
  Last update: 2010-03-02 21:53    [W:0.085 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site