lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC tip/core/rcu 1/2] rcu: suppress RCU lockdep warnings during early boot
On Tue, Mar 02, 2010 at 01:20:59PM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
>
> > + if (!rcu_scheduler_active || !debug_locks)
> > + return 1;
> > + return lock_is_held(&rcu_lock_map);
>
> > + if (!rcu_scheduler_active || !debug_locks)
> > + return 1;
> > + return lock_is_held(&rcu_bh_lock_map);
>
> i guess there could be a common helper here?

Will do!

> Also, could we clear rcu_scheduler_active when we clear debug_locks? That way
> only a single test is needed, a generic 'is lock debugging active'.

Doing that will break synchronize_rcu(), which returns immediately if
!rcu_scheduler_active.

> (Which test should probably be unlikely() as well?)

Good point, will fix.

Thanx, Paul


\
 
 \ /
  Last update: 2010-03-02 14:29    [W:0.050 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site