Messages in this thread Patch in this message | | | Date | Fri, 19 Mar 2010 14:44:11 +0300 | From | Dan Carpenter <> | Subject | [patch] sbshc: acpi_device_class "smbus_host_controller" too long |
| |
acpi_device_class can only be 19 characters and a NULL terminator.
With the current name we get a buffer overflow in acpi_smbus_hc_add() when we do: strcpy(acpi_device_class(device), ACPI_SMB_HC_CLASS);
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c index fd09229..1fbf073 100644 --- a/drivers/acpi/sbshc.c +++ b/drivers/acpi/sbshc.c @@ -17,7 +17,7 @@ #define PREFIX "ACPI: " -#define ACPI_SMB_HC_CLASS "smbus_host_controller" +#define ACPI_SMB_HC_CLASS "smbus_host_ctl" #define ACPI_SMB_HC_DEVICE_NAME "ACPI SMBus HC" struct acpi_smb_hc {
| |