lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/12] sysfs: Initialised pci bus legacy_mem field before use
    Date
    From: Mel Gorman <mel@csn.ul.ie>

    PPC64 is failing to boot the latest mmotm due to an uninitialised pointer in
    pci_create_legacy_files(). The surprise is that machines boot at all and it
    would appear to affect current mainline as well. This patch fixes the problem.

    Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/pci/pci-sysfs.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
    index de29645..9976685 100644
    --- a/drivers/pci/pci-sysfs.c
    +++ b/drivers/pci/pci-sysfs.c
    @@ -655,8 +655,8 @@ void pci_create_legacy_files(struct pci_bus *b)
    goto legacy_io_err;

    /* Allocated above after the legacy_io struct */
    - sysfs_bin_attr_init(b->legacy_mem);
    b->legacy_mem = b->legacy_io + 1;
    + sysfs_bin_attr_init(b->legacy_mem);
    b->legacy_mem->attr.name = "legacy_mem";
    b->legacy_mem->size = 1024*1024;
    b->legacy_mem->attr.mode = S_IRUSR | S_IWUSR;
    --
    1.7.0.2


    \
     
     \ /
      Last update: 2010-03-19 16:23    [W:0.027 / U:60.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site