lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] tty: cpm_uart: use resource_size()
    Date
    From: Tobias Klauser <tklauser@distanz.ch>

    Use the resource_size function instead of manually calculating the
    resource size. This reduces the chance of introducing off-by-one errors.

    Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Kumar Gala <galak@gate.crashing.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/serial/cpm_uart/cpm_uart_cpm2.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)
    diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
    index a9802e7..722eac1 100644
    --- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
    +++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
    @@ -61,7 +61,7 @@ void __iomem *cpm_uart_map_pram(struct uart_cpm_port *port,
    void __iomem *pram;
    unsigned long offset;
    struct resource res;
    - unsigned long len;
    + resource_size_t len;

    /* Don't remap parameter RAM if it has already been initialized
    * during console setup.
    @@ -74,7 +74,7 @@ void __iomem *cpm_uart_map_pram(struct uart_cpm_port *port,
    if (of_address_to_resource(np, 1, &res))
    return NULL;

    - len = 1 + res.end - res.start;
    + len = resource_size(&res);
    pram = ioremap(res.start, len);
    if (!pram)
    return NULL;
    --
    1.7.0.2


    \
     
     \ /
      Last update: 2010-03-19 16:21    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean