Messages in this thread | | | Subject | Re: [PATCH v2 1/7] wireless.h: Add STD_IW_HANDLER macro | From | Joe Perches <> | Date | Thu, 18 Mar 2010 10:37:00 -0700 |
| |
On Thu, 2010-03-18 at 13:23 -0400, Pavel Roskin wrote: > On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote: > > Copied from orinoco, initialize a iw_handler array entry > > +#define STD_IW_HANDLER(id, func) \ > > + [IW_IOCTL_IDX(id)] = (iw_handler) func > Three objections. > 1) STD_IW_HANDLER is a poor name for a header. The name should start > with IW, just like those above and below it.
Is IW_HANDLER ok with you?
> 3) Abstracting a cast is bad unless it's the whole purpose of the macro. > While Orinoco needs the cast, other drivers may not need it. Using a > cast could prevent gcc from finding a legitimate problem.
I've no objection to moving the casts to the uses of the macro where necessary.
| |