lkml.org 
[lkml]   [2010]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [V2 PATCH 08/10] arch/powerpc: Remove obsolete dev_archdata.of_node and of_devce.node
    Hi Grant,

    On Thu, Mar 18, 2010 at 09:22:50AM -0600, Grant Likely wrote:
    > Both dev_archdata.of_node and of_device.node are duplications of the
    > device.of_node value. This patch removes them.

    Yeah, they're plain duplications since you introduced dev.of_node.
    I wonder what was the problem with using dev.archdata.of_node?
    Why dev.of_node is better?

    Also, by using dev.of_node directly you have to introduce ugly
    #ifdefs in the non-OF code (as in i2c patch), which you don't
    need with transparent archdata and accessors, which you've just
    removed:

    > -static inline void dev_archdata_set_node(struct dev_archdata *ad,
    > - struct device_node *np)
    > -{
    > - ad->of_node = np;
    > -}
    > -
    > -static inline struct device_node *
    > -dev_archdata_get_node(const struct dev_archdata *ad)
    > -{
    > - return ad->of_node;
    > -}

    Thanks,

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2


    \
     
     \ /
      Last update: 2010-03-18 16:51    [W:0.021 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site