lkml.org 
[lkml]   [2010]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Patch inclusion in stable
On Thu, Mar 18, 2010 at 01:32:33PM +0200, Surbhi Palande wrote:
> Hi All,
>
> I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st
> patch in the series:
>
> commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>
> airo: fix setting zero length WEP key
>
> The linux-2.6 source has another patch that adds the following line:
> if (WARN_ON(keylen == 0))
> >> + return -1;
>
> This is added through the commit
> 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the
> 2.6.32.10 stable patches. I think it should be a part of stable patches
> too.

keylen == 0 is just bug and should never happen. As we are printing
calltrace in such situation user is informed of a bug. Return from
function in that case is nice, but not strictly necessary.

Cheers
Stanislaw


\
 
 \ /
  Last update: 2010-03-18 13:21    [from the cache]
©2003-2011 Jasper Spaans