Messages in this thread | | | Date | Thu, 18 Mar 2010 10:02:37 +0800 | From | Cong Wang <> | Subject | Re: [Patch] netpoll: warn when there are spaces in parameters |
| |
Frans Pop wrote: > Amerigo Wang wrote: >> + if (*cur == ' ' || *cur == '\t') >> + printk(KERN_INFO "%s: warning: white spaces" >> + "are not allowed.\n", np->name); >> > > The term "white spaces" not correct. Please change the message to > "whitespace is not allowed". > > Also, it's normally not necessary to close kernel messages with a period; > most kernel messages do not have a closing period. Messages are not > sentences and the periods only help increase the kernel size. >
Ok, I will update it.
Thanks.
| |