[lkml]   [2010]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -mmotm 1/5] memcg: disable irq at page cgroup lock
* Andrea Righi <> [2010-03-15 00:26:38]:

> From: KAMEZAWA Hiroyuki <>
> Now, file-mapped is maintaiend. But more generic update function
> will be needed for dirty page accounting.
> For accountig page status, we have to guarantee lock_page_cgroup()
> will be never called under tree_lock held.
> To guarantee that, we use trylock at updating status.
> By this, we do fuzzy accounting, but in almost all case, it's correct.

I don't like this at all, but in almost all cases is not acceptable
for statistics, since decisions will be made on them and having them
incorrect is really bad. Could we do a form of deferred statistics and
fix this.

Three Cheers,

 \ /
  Last update: 2010-03-17 13:01    [W:0.160 / U:6.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site