lkml.org 
[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [tip:sched/urgent] sched: sched_getaffinity(): Allow less than NR_CPUS length
Date
> 
> * tip-bot for KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
> > Commit-ID: cd3d8031eb4311e516329aee03c79a08333141f1
> > Gitweb: http://git.kernel.org/tip/cd3d8031eb4311e516329aee03c79a08333141f1
> > Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > AuthorDate: Fri, 12 Mar 2010 16:15:36 +0900
> > Committer: Ingo Molnar <mingo@elte.hu>
> > CommitDate: Mon, 15 Mar 2010 08:28:44 +0100
> >
> > sched: sched_getaffinity(): Allow less than NR_CPUS length
>
> > + int retlen = min(len, cpumask_size());
>
> this one causes:
>
> kernel/sched.c:4850: warning: comparison of distinct pointer types lacks a cast

Ahh, I'm sorry. attached fixing patch.

thanks.


============================
Subject: [PATCH] fix warning
fix following warning.

kernel/sched.c:4850: warning: comparison of distinct pointer types lacks
a cast

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
kernel/sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 34217f1..d1d5acd 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4912,7 +4912,7 @@ SYSCALL_DEFINE3(sched_getaffinity, pid_t, pid, unsigned int, len,

ret = sched_getaffinity(pid, mask);
if (ret == 0) {
- int retlen = min(len, cpumask_size());
+ size_t retlen = min_t(size_t, len, cpumask_size());

if (copy_to_user(user_mask_ptr, mask, retlen))
ret = -EFAULT;
--
1.6.5.2




\
 
 \ /
  Last update: 2010-03-17 01:39    [from the cache]
©2003-2011 Jasper Spaans