lkml.org 
[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] devtmpfs: support !CONFIG_TMPFS
    Date
    >>>>> "Greg" == Greg KH <greg@kroah.com> writes:

    Hi,

    >> config DEVTMPFS
    >> bool "Maintain a devtmpfs filesystem to mount at /dev"
    >> - depends on HOTPLUG && SHMEM && TMPFS
    >> + depends on HOTPLUG
    >> help
    >> This creates a tmpfs filesystem instance early at bootup.
    >> In this filesystem, the kernel driver core maintains device

    Greg> With this patch, the Kconfig help text now is incorrect.

    Greg> Is there a way to explicitly call out in the Kconfig which way
    Greg> devtmpfs is being created? How about a multiple selection that
    Greg> chooses either TMPFS or RAMFS, with the default being TMPFS?

    I don't think that's needed - If CONFIG_TMPFS isn't set, then ramfs
    pretends to be tmpfs anyway, see mm/shmem.c:

    static struct file_system_type tmpfs_fs_type = {
    .name = "tmpfs",
    .get_sb = ramfs_get_sb,
    .kill_sb = kill_litter_super,
    };

    So calling it tmpfs isn't really wrong.

    Greg> So care to redo this so that people can easily determine what is going
    Greg> to happen easier than this patch currently causes?

    We can change the help text to say tmpfs/ramfs if you prefer - OK?

    --
    Bye, Peter Korsgaard


    \
     
     \ /
      Last update: 2010-03-16 20:17    [W:0.023 / U:33.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site