lkml.org 
[lkml]   [2010]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vfs: pass struct file to do_truncate on O_TRUNC opens
On Mon, Mar 15, 2010 at 10:50:37PM +0000, Al Viro wrote:
> On Mon, Mar 15, 2010 at 06:47:02PM -0400, Jeff Layton wrote:
>
> > Yeah that would be cleaner on the wire for the create case. It's not
> > clear to me how to implement that though. There doesn't appear to be
> > a straightforward way to tell the VFS to skip the truncate.
>
> The plan is to turn most of the guts of do_last() into fs method...

For union mounts, we will want to skip the truncate too (or else
insinuate ourselves into do_truncate() - less attractive). This is
because we want to only copy up the bytes that are not being
truncated, instead of copying up the file contents and then throwing
them away.

What's the timing on the do_last() change? Do you know what branch it
will be in?

Thanks,

-VAL


\
 
 \ /
  Last update: 2010-03-16 18:51    [W:0.058 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site