Messages in this thread | | | Date | Tue, 16 Mar 2010 13:11:42 -0400 | From | James Smart <> | Subject | Re: [PATCH 2/3] SCSI: lpfc, fix lock imbalances |
| |
Acked-By: James Smart <james.smart@emulex.com>
-- james s
Jiri Slaby wrote: > Stanse found that two error paths in lpfc_bsg_rport_els_cmp and > lpfc_issue_ct_rsp_cmp omits to unlock phba->ct_ev_lock. It is > because they wrongly unlock phba->hbalock instead. Fix that. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: James Smart <james.smart@emulex.com> > Cc: James Bottomley <James.Bottomley@suse.de> > --- > drivers/scsi/lpfc/lpfc_bsg.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c > index 692c29f..992efb1 100644 > --- a/drivers/scsi/lpfc/lpfc_bsg.c > +++ b/drivers/scsi/lpfc/lpfc_bsg.c > @@ -432,7 +432,7 @@ lpfc_bsg_rport_els_cmp(struct lpfc_hba *phba, > dd_data = cmdiocbq->context1; > /* normal completion and timeout crossed paths, already done */ > if (!dd_data) { > - spin_unlock_irqrestore(&phba->hbalock, flags); > + spin_unlock_irqrestore(&phba->ct_ev_lock, flags); > return; > } > > @@ -1195,7 +1195,7 @@ lpfc_issue_ct_rsp_cmp(struct lpfc_hba *phba, > dd_data = cmdiocbq->context1; > /* normal completion and timeout crossed paths, already done */ > if (!dd_data) { > - spin_unlock_irqrestore(&phba->hbalock, flags); > + spin_unlock_irqrestore(&phba->ct_ev_lock, flags); > return; > } >
| |