Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance | Date | Tue, 16 Mar 2010 16:23:59 +0100 |
| |
Stanse found that one error path in qla24xx_bsg_timeout omits to unlock ha->hardware_lock. Fix that.
Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Giridhar Malavali <giridhar.malavali@qlogic.com> Cc: James Bottomley <James.Bottomley@suse.de> --- drivers/scsi/qla2xxx/qla_attr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 90d1e06..a3591e5 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -2388,6 +2388,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job) return 0; done: + spin_unlock_irqrestore(&ha->hardware_lock, flags); if (bsg_job->request->msgcode == FC_BSG_HST_CT) kfree(sp->fcport); kfree(sp->ctx); -- 1.7.0.1
| |