Messages in this thread | | | Date | Tue, 16 Mar 2010 12:24:36 +0200 | From | Török Edwin <> | Subject | Re: [PATCH] perf: install into /usr/local by default. |
| |
On 03/16/2010 12:10 PM, Ingo Molnar wrote: > * T??r??k Edwin <edwintorok@gmail.com> wrote: > >> It was confusing to install into $(HOME)/bin, especially since there was >> no documentation mentioning where perf gets installed by default. >> So install to /usr/local by default, as other programs do, and allow users to >> override the install location by specifying the prefix explicitly. >> >> Signed-off-by: T??r??k Edwin <edwintorok@gmail.com> >> --- >> tools/perf/Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/tools/perf/Makefile b/tools/perf/Makefile >> index 2e7fa3a..8e8c199 100644 >> --- a/tools/perf/Makefile >> +++ b/tools/perf/Makefile >> @@ -216,7 +216,7 @@ STRIP ?= strip >> # runtime figures out where they are based on the path to the executable. >> # This can help installing the suite in a relocatable way. >> >> -prefix = $(HOME) >> +prefix = /usr/local >> bindir_relative = bin >> bindir = $(prefix)/$(bindir_relative) >> mandir = share/man > > Btw., we inherited that default prefix from the Git project. > > Is there a way to get it into ~/bin/ if the user does not have permission to > /usr/local ? (i.e. doesnt run it as root)
That is complicated, I usually run make as a normal user, and only do make install as root (or sudo make install). I do that for the kernel itself, and usually every program I build (I don't like compiling as root).
> > That's a really convenient aspect of doing a 'make install' as user. (Which i > tend to do in most cases)
On 03/16/2010 12:20 PM, Avi Kivity wrote: > What about people (like me) who do 'make && sudo make install'? > > Can we make it position independent and derive the path from /proc/$$/exe? >
There is a RUNTIME_PREFIX define (undocumented...) that seems to do something like that. Are there any security implications of using that by default?
Best regards, --Edwin
| |