lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] init dynamic bin_attribute structures
    On Mon, 15 Mar 2010, Wolfram Sang wrote:

    > Commit 6992f5334995af474c2b58d010d08bc597f0f2fe introduced this requirement.
    > First, at25 was fixed manually. Then, other occurences were found with
    > coccinelle and the following semantic patch. Results were reviewed and fixed
    > up:
    >
    > @ init @
    > identifier struct_name, bin;
    > @@
    >
    > struct struct_name {
    > ...
    > struct bin_attribute bin;
    > ...
    > };
    >
    > @ main extends init @
    > expression E;
    > statement S;
    > identifier name, err;
    > @@
    >
    > (
    > struct struct_name *name;
    > |
    > - struct struct_name *name = NULL;
    > + struct struct_name *name;
    > )
    > ...
    > (
    > sysfs_bin_attr_init(&name->bin);
    > |
    > + sysfs_bin_attr_init(&name->bin);
    > if (sysfs_create_bin_file(E, &name->bin))
    > S
    > |
    > + sysfs_bin_attr_init(&name->bin);
    > err = sysfs_create_bin_file(E, &name->bin);
    > )
    >
    > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    > Cc: Eric W. Biederman <ebiederm@xmission.com>
    > Cc: Linus Torvalds <torvalds@linux-foundation.org>
    > ---
    > arch/mips/txx9/generic/setup.c | 1 +
    > drivers/misc/eeprom/at25.c | 1 +
    > drivers/rtc/rtc-ds1742.c | 1 +
    > 3 files changed, 3 insertions(+), 0 deletions(-)

    I don't understand how cocinelle works, but the resulting patch seems to
    be incomplete.

    The fix is needed at least in firmware loader (for which Greg has already
    queued patch), in ACPI thermal driver [1], etc).

    [1] http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/02680.html

    --
    Jiri Kosina
    SUSE Labs, Novell Inc.



    \
     
     \ /
      Last update: 2010-03-15 11:03    [W:0.039 / U:60.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site