lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: wlan-ng: fix coding style in hfa834x_usb.c
On 13/03/10 01:07, ehames@gmail.com wrote:
> From: Edgardo Hames <ehames@gmail.com>
>
> This is a patch in hfa834x_usb.c to fix typedef declarations and long lines.
>
> Signed-off-by: Edgardo Hames <ehames@gmail.com>
> ---
Hi Edgardo,

Definitely a good thing to get rid of the typedefs.

> printk(KERN_ERR
> - "cmd_initialize() failed on two attempts, results %d and %d\n",
> - result1, result2);
> + "cmd_initialize() failed on two attempts,"
> + " results %d and %d\n", result1, result2);
> usb_kill_urb(&hw->rx_urb);

But I don't think you should split up the printk strings (like this one)
as it make them difficult to grep for.


> @@ -3382,8 +3382,9 @@ retry:
> * our request has been acknowledged. Odd,
> * but our OUT URB is still alive...
> */
> - pr_debug
> - ("Causality violation: please reboot Universe, or email linux-wlan-devel@lists.linux-wlan.com\n");
> + pr_debug("Causality violation: "
> + "please reboot Universe, or email "
> + "linux-wlan-devel@lists.linux-wlan.com\n");
> ctlx->state = CTLX_RESP_COMPLETE;
> break;

This mailing list is dead, so there's no point in still directing people
there, so you can just drop the second half of that message.

regards
Richard



\
 
 \ /
  Last update: 2010-03-15 10:57    [W:0.050 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site