[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[RFC]cfq-iosched: fix a kbuild regression
Alex Shi reported a kbuild regression which is about 10% performance lost.
He bisected to this commit: 3dde36ddea3e07dd025c4c1ba47edec91606fec0.
The reason is cfqq_close() can't find close cooperator. If we store the seek
distance to the value before the commit like below, the regression fully goes
away. If this is too invasive, just changing the cfq_rq_close() for the
!for_preempt is ok too.

Reported-by: Alex Shi <>
Signed-off-by: Shaohua Li <>

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index dee9d93..fcae456 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -46,7 +46,7 @@ static const int cfq_hist_divisor = 4;
#define CFQ_HW_QUEUE_MIN (5)

-#define CFQQ_SEEK_THR (sector_t)(8 * 100)
+#define CFQQ_SEEK_THR (sector_t)(8 * 1024)
#define CFQQ_SECT_THR_NONROT (sector_t)(2 * 32)
#define CFQQ_SEEKY(cfqq) (hweight32(cfqq->seek_history) > 32/8)

 \ /
  Last update: 2010-03-16 04:01    [W:0.066 / U:3.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site