Messages in this thread | | | From | Karsten Keil <> | Subject | Re: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe | Date | Tue, 16 Mar 2010 02:08:57 +0100 |
| |
On Dienstag, 16. März 2010 00:01:33 David Miller wrote: > From: Karsten Keil <keil@b1-systems.de> > Date: Mon, 15 Mar 2010 14:18:41 +0100 > > > A few subdevice IDs seem to have been dropped when hfc_multi was > > included upstream, just compare the list at > > http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=ann > >otate#l175 with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c > > > > Added PCIe 2 Port card and LED settings (same as PCI) /KKe > > > > Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com> > > Signed-off-by: Karsten Keil <keil@b1-systems.de> > > We don't add new defines to linux/pci_ids.h, it is deprecated. > Simply add the device ID constants to the table.
Good policy, makes sense. Will send a new version. May a check for adding defines to <linux/pci_ids> would help to enforce it.
> > The only exception is the case where a device ID is used in > more than one driver, but even that scenerio is heavily > discouraged. >
Is here some plan to cleanup drivers for -next and remove IDs from pci_ids.h, or should it not changed for old entries ?
Karsten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |