[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe
On Dienstag, 16. März 2010 00:01:33 David Miller wrote:
> From: Karsten Keil <>
> Date: Mon, 15 Mar 2010 14:18:41 +0100
> > A few subdevice IDs seem to have been dropped when hfc_multi was
> > included upstream, just compare the list at
> >
> >otate#l175 with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c
> >
> > Added PCIe 2 Port card and LED settings (same as PCI) /KKe
> >
> > Signed-off-by: Lars Ellenberg <>
> > Signed-off-by: Karsten Keil <>
> We don't add new defines to linux/pci_ids.h, it is deprecated.
> Simply add the device ID constants to the table.

Good policy, makes sense. Will send a new version.
May a check for adding defines to <linux/pci_ids> would help to enforce it.

> The only exception is the case where a device ID is used in
> more than one driver, but even that scenerio is heavily
> discouraged.

Is here some plan to cleanup drivers for -next and remove IDs from pci_ids.h,
or should it not changed for old entries ?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-03-16 02:11    [W:0.039 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site