lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86: handle legacy PIC interrupts on all the cpu's
On 03/15/2010 03:56 PM, Suresh Siddha wrote:
> On Mon, 2010-03-15 at 14:51 -0700, Yinghai Lu wrote:
>>> + for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
>>> + if (!IO_APIC_IRQ(irq))
>>> + per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
>>
>> seems those three lines are not needed...
>
> Those are needed for !CONFIG_X86_IO_APIC case.
>
then we can have

+#ifndef CONFIG_X86_IO_APIC
+ for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
+ per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
+#endif

then we don't punish most setup with ioapic controller.

Yinghai


\
 
 \ /
  Last update: 2010-03-15 23:19    [W:0.051 / U:33.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site