lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g
I have a patch awaiting net-next that does these kinds of things.  I
can roll (most of) Steven's changes into that patch and get it all
done in one shot if you like.

On Sat, Mar 13, 2010 at 12:22:22PM -0800, Joe Perches wrote:
> On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> > From: Steven Harms <thisdyingdream@gmail.com>
> > Date: Sat, 13 Mar 2010 14:52:26 -0500
> >
> > > Would you like me to submit the patch adding only the spaces after
> > > commas and leave the rest of the defines as is, or discard the changes
> > > all together?
> >
> > I would like you to toss them altogether.
>
> I think that Steven got off on the wrong foot
> a bit by adding the parentheses to the defines.
>
> I think the other changes he suggested are
> tree-wide style consistency only and are ok.
>
> Perhaps you might reconsider later, after
> net-next reopens.
>
>
>



\
 
 \ /
  Last update: 2010-03-15 19:41    [W:0.056 / U:24.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site