lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: pcmcia's use of IRQ_NOAUTOEN
Hey,

On Mon, Mar 15, 2010 at 05:43:59PM +0000, Alan Cox wrote:
> > You're right, it seems to make no sense. Or less than that.
> >
> > Alan, what do you think?
>
> It should be setting the correct NOAUTOEN bits so that the IRQ isn't
> randomly enabled as some hardware then crashes. How it ended up wrong
> upstream I don't know as it was tested and fixed the bug, so presumably
> the right version got tested or it happened to work back on the old irq
> code by luck.

http://lkml.org/lkml/2007/4/5/127 and then
http://lkml.org/lkml/2007/4/26/485 talk a different language :(

> I don't think you are overlooking anything - there is no deep magic
> involved.

I'll just revert it.

Best,
Dominik


\
 
 \ /
  Last update: 2010-03-15 19:21    [W:0.040 / U:42.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site