lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h
    On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
    > From: Chihau Chau <chihau@gmail.com>
    >
    > This is moving toward using <linux/uaccess.h> instead of the old
    > <asm/uaccess.h> file.

    Changelog does not match the patch.

    ...plus, was the patch actually tested?
    Pavel

    > --- a/drivers/staging/dream/generic_gpio.c
    > +++ b/drivers/staging/dream/generic_gpio.c
    > @@ -18,7 +18,7 @@
    > #include <linux/errno.h>
    > #include <linux/slab.h>
    > #include <linux/spinlock.h>
    > -#include <asm/gpio.h>
    > +#include <linux/gpio.h>
    > #include "gpio_chip.h"
    >
    > #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2010-03-15 06:37    [W:0.020 / U:59.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site