lkml.org 
[lkml]   [2010]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH V2 2/2] cpuset: alloc nodemask_t at heap not stack - fix
Changes from V1 to V2:
- remove unnecessary checking.

fix memory leak

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
---
Against the following patch in mmotm-2010-03-11-13-13:
cpuset-alloc-nodemask_t-at-heap-not-stack.patch
---
kernel/cpuset.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index f36e577..02b4545 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1401,7 +1401,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,
NODEMASK_ALLOC(nodemask_t, to, GFP_KERNEL);

if (from == NULL || to == NULL)
- return;
+ goto alloc_fail;

if (cs == &top_cpuset) {
cpumask_copy(cpus_attach, cpu_possible_mask);
@@ -1432,6 +1432,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,
mmput(mm);
}

+alloc_fail:
NODEMASK_FREE(from);
NODEMASK_FREE(to);
}
--
1.6.5.2



\
 
 \ /
  Last update: 2010-03-15 06:23    [W:0.020 / U:3.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site