lkml.org 
[lkml]   [2010]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 01/11] mm,migration: Take a reference to the anon_vma before migrating
    From
    On Sat, Mar 13, 2010 at 1:41 AM, Mel Gorman <mel@csn.ul.ie> wrote:
    > rmap_walk_anon() does not use page_lock_anon_vma() for looking up and
    > locking an anon_vma and it does not appear to have sufficient locking to
    > ensure the anon_vma does not disappear from under it.
    >
    > This patch copies an approach used by KSM to take a reference on the
    > anon_vma while pages are being migrated. This should prevent rmap_walk()
    > running into nasty surprises later because anon_vma has been freed.
    >
    > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    > Acked-by: Rik van Riel <riel@redhat.com>
    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

    BTW, This another refcount of anon_vma is merged with KSM by [3/11].
    Looks good to me.


    --
    Kind regards,
    Minchan Kim


    \
     
     \ /
      Last update: 2010-03-14 16:03    [W:0.020 / U:0.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site