Messages in this thread | | | Subject | Re: [PATCH] vsprintf.c: Use noinline_for_stack | From | Joe Perches <> | Date | Sat, 13 Mar 2010 09:44:55 -0800 |
| |
On Sat, 2010-03-13 at 07:35 -0800, Linus Torvalds wrote: > On Fri, 12 Mar 2010, Andrew Morton wrote: > > nice. > But the kallsyms_lookup()/sprint_symbol() functions don't take a > length parameter, so we have to do the worst-case thing (which itself has > tons of unnecessary padding).
I sent a patch once about that using a struct because I didn't like the unbounded sprint http://lkml.org/lkml/2009/4/15/16
> Gaah. We do _not_ want a kmalloc() or something like that in this path, > since its' very much used for oopses (which in turn may be due to various > slab bugs etc).
Perhaps a new snprint_symbol function with the other kallsyms... functions changed as necessary.
thoughts?
| |