Messages in this thread | | | Date | Fri, 12 Mar 2010 22:15:27 -0500 | Subject | Re: Using tracing_off() in __schedule_bug() | From | Chase Douglas <> |
| |
On Fri, Mar 12, 2010 at 10:09 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > On Fri, 2010-03-12 at 21:50 -0500, Chase Douglas wrote: >> On Fri, Mar 12, 2010 at 9:30 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > >> I was thinking that there may be times where you want to skip warnings >> to trace real bugs. For example, there's a WARNING that you hit if >> your resume takes too long. I may want to skip that warning for the >> oops that occurs just after it. As a distro, we also want to be >> flexible in our official kernels so we don't have to build special >> ones when people hit bugs. It's not as though it would be very >> difficult to design with a few priorities, so unless it's really >> unnecessary I don't see why we shouldn't. The default would also fire >> tracing_off in all cases, so most people wouldn't have to modify it >> unless they hit a corner case. > > I'm fine with having a two layer. Stop tracing on bugs and/or on > warnings. I would actually have disable on warnings be default off. > There are too many kernel warnings that trigger too easily, having your > resume warning be one of them. > > I'm still not sure we need a separate one for critical errors. A oops, > panic and BUG should all be the same. Since any of them can cause the > system to halt.
That sounds fine to me. I'll work on a patch for this.
-- Chase
| |