lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: pci: code style cleanup
On Thu, 11 Mar 2010 14:53:03 -0300
Chihau Chau <chihau@gmail.com> wrote:

> From: Chihau Chau <chihau@gmail.com>
>
> This is a code style cleanup related with spaces, like a lot of trailing
> withspaces, spaces before a TAB, to use "foo * bar" instead of "foo *bar"
> and to put a else sentence below close brace '}'.
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>

Unless you're doing some other work in this area and include this patch
in a larger patchset, I'm inclined to reject it, since it just creates
churn for others for no good reason.

In other words, if developer A is making real changes in these areas
that would invalidate developer B's patches, that's fine. But I don't
think it's ok to let cleanup patches invalidate developer B's work.

Hope that's clear. Don't get me wrong, I like the fact that in Linux
we're not afraid to clean stuff up. I just don't like it getting in
the way of real work.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2010-03-13 02:31    [W:0.192 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site