Messages in this thread | | | Date | Fri, 12 Mar 2010 17:27:38 -0800 | From | Jesse Barnes <> | Subject | Re: [PATCH] Drivers: pci: code style cleanup |
| |
On Thu, 11 Mar 2010 14:53:03 -0300 Chihau Chau <chihau@gmail.com> wrote:
> From: Chihau Chau <chihau@gmail.com> > > This is a code style cleanup related with spaces, like a lot of trailing > withspaces, spaces before a TAB, to use "foo * bar" instead of "foo *bar" > and to put a else sentence below close brace '}'. > > Signed-off-by: Chihau Chau <chihau@gmail.com>
Unless you're doing some other work in this area and include this patch in a larger patchset, I'm inclined to reject it, since it just creates churn for others for no good reason.
In other words, if developer A is making real changes in these areas that would invalidate developer B's patches, that's fine. But I don't think it's ok to let cleanup patches invalidate developer B's work.
Hope that's clear. Don't get me wrong, I like the fact that in Linux we're not afraid to clean stuff up. I just don't like it getting in the way of real work.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |