lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[057/145] rndis_wlan: disable stall workaround
    2.6.32-stable review patch.  If anyone has any objections, please let me know.

    ----------------
    From: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>

    commit 77593ae28c4c134eaf28ef34ecac3cd4464ecd6e upstream.

    Stall workaround doesn't work with bcm4320a devices like with bcm4320b.
    This workaround actually causes more stalls/device freeze on bcm4320a.
    Therefore disable stall workaround by default.

    Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/rndis_wlan.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/net/wireless/rndis_wlan.c
    +++ b/drivers/net/wireless/rndis_wlan.c
    @@ -83,11 +83,11 @@ MODULE_PARM_DESC(roamdelta,
    "set roaming tendency: 0=aggressive, 1=moderate, "
    "2=conservative (default: moderate)");

    -static int modparam_workaround_interval = 500;
    +static int modparam_workaround_interval;
    module_param_named(workaround_interval, modparam_workaround_interval,
    int, 0444);
    MODULE_PARM_DESC(workaround_interval,
    - "set stall workaround interval in msecs (default: 500)");
    + "set stall workaround interval in msecs (0=disabled) (default: 0)");


    /* various RNDIS OID defs */
    @@ -2550,7 +2550,7 @@ static void rndis_device_poller(struct w
    /* Workaround transfer stalls on poor quality links.
    * TODO: find right way to fix these stalls (as stalls do not happen
    * with ndiswrapper/windows driver). */
    - if (priv->last_qual <= 25) {
    + if (priv->param_workaround_interval > 0 && priv->last_qual <= 25) {
    /* Decrease stats worker interval to catch stalls.
    * faster. Faster than 400-500ms causes packet loss,
    * Slower doesn't catch stalls fast enough.



    \
     
     \ /
      Last update: 2010-03-13 01:57    [W:0.020 / U:117.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site