lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] XEN: Make handle_vcpu_hotplug_event() to check the sscanf() return value
On 03/11/2010 06:53 PM, wzt.wzt@gmail.com wrote:
> It seems handle_vcpu_hotplug_event() not check the sscanf() return value.
>
> Signed-off-by: Zhitong Wang<zhitong.wangzt@alibaba-inc.com>
>

Good catch, thanks.

J

> ---
> drivers/xen/cpu_hotplug.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index 14e2d99..99773a6 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -69,8 +69,8 @@ static void handle_vcpu_hotplug_event(struct xenbus_watch *watch,
>
> cpustr = strstr(node, "cpu/");
> if (cpustr != NULL) {
> - sscanf(cpustr, "cpu/%u",&cpu);
> - vcpu_hotplug(cpu);
> + if (sscanf(cpustr, "cpu/%u",&cpu) == 1)
> + vcpu_hotplug(cpu);
> }
> }
>
>



\
 
 \ /
  Last update: 2010-03-13 01:41    [W:0.036 / U:4.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site