lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[003/145] V4L/DVB: dvb: l64781.ko broken with gcc 4.5
    2.6.32-stable review patch.  If anyone has any objections, please let me know.

    ----------------
    From: Richard Guenther <rguenther@suse.de>

    commit c1db53b36633e6a7511dbec7c372f01a31528f0c upstream.

    I'm trying to fix it on the GCC side (PR43007), but the module is
    quite stupid in using ULL constants to operate on u32 values:

    static int apply_frontend_param (struct dvb_frontend* fe, struct
    dvb_frontend_parameters *param)
    {
    ...
    static const u32 ppm = 8000;
    u32 spi_bias;
    ...

    spi_bias *= 1000ULL;
    spi_bias /= 1000ULL + ppm/1000;

    which causes current GCC 4.5 to emit calls to __udivdi3 for i?86 again.

    This patch fixes this issue.

    Signed-off-by: Richard Guenther <rguenther@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

    ---
    drivers/media/dvb/frontends/l64781.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/media/dvb/frontends/l64781.c
    +++ b/drivers/media/dvb/frontends/l64781.c
    @@ -192,8 +192,8 @@ static int apply_frontend_param (struct
    spi_bias *= qam_tab[p->constellation];
    spi_bias /= p->code_rate_HP + 1;
    spi_bias /= (guard_tab[p->guard_interval] + 32);
    - spi_bias *= 1000ULL;
    - spi_bias /= 1000ULL + ppm/1000;
    + spi_bias *= 1000;
    + spi_bias /= 1000 + ppm/1000;
    spi_bias *= p->code_rate_HP;

    val0x04 = (p->transmission_mode << 2) | p->guard_interval;



    \
     
     \ /
      Last update: 2010-03-13 01:33    [W:0.021 / U:60.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site