lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 0 of 5] PV on HVM Xen
On 03/12/2010 02:42 AM, Stefano Stabellini wrote:
> On Fri, 12 Mar 2010, Sheng Yang wrote:
>
>> On Wednesday 10 March 2010 23:46:54 Stefano Stabellini wrote:
>>
>>> Hi all,
>>>
>> Stefano,
>>
>> And next time when you send out the patch, please be more respect to my work.
>>
>> You dropped all the original author(me) of patchset, and only add a sign-off
>> for me. If you don't aware the difference, here is a snippet of
>> linux/Documentation/SummittingPatches
>>
>>
> I am truly sorry and apologise for it, I would never want to give you
> the impression of being disrespectful of you and your work.
> If you pay attention I manually wrote in the comments of all the past
> versions of the patches that you were the original author, this time I
> just forgot.
> I guess it is really the time I start using git-send-email :)
>
> Your work has been really important for my series and you deserve the
> credit for it independently from which patch series gets applied.
>

Best practise for this kind of thing is to use Sheng's patch verbatim,
then apply a separate delta on top to make the changes you want. That way:

* credit can be property attributed
* it helps with maintaining two parallel-but-converging git
branches, because all the common stuff is genuinely common, and
the variations can work from there, and
* if Sheng updates his patches (review, bugfix, etc), then we can
easily see how those changes affect your changes.

For example, I just rebased your previous patch posting so that it is
rooted on Sheng's two base patches, as they're completely common.

The latest of both patches is in xen/pvhvm-sheng and -stefano.

J


\
 
 \ /
  Last update: 2010-03-12 22:55    [W:0.049 / U:6.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site