lkml.org 
[lkml]   [2010]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/5] perf report: Initial TUI using newt
Em Fri, Mar 12, 2010 at 11:55:04AM +0200, Avi Kivity escreveu:
> On 03/12/2010 11:45 AM, Ingo Molnar wrote:
>>
>> - When i hit enter on a symbol to annotate it, but the annotation fails, the TUI
>> just does nothing currently. Instead it should print something informative
>> (and eye-catching) into a status line at the top or the bottom of the
>> screen, possibly printed in red characters or so. Not a separate window as that
>> needs extra key-hits to get rid of - just a sufficiently visible status
>> line would be perfect. There can be a few reasons why some functions can be
>> annotated while others cannot be.
>
> Alternatively, mark it as unannotatable in the first place (e.g. an
> annotatable symbol is a hyperlink, an unannotatable one is not). But
> perhaps that's too computationally expensive.

I'll come up with some way to do that, changing the color or adding
markings to highlight the top functions, like the stdio one does with
red for te top functions, etc is needed.

- Arnaldo


\
 
 \ /
  Last update: 2010-03-12 14:31    [W:0.042 / U:26.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site