Messages in this thread | | | From | Kay Sievers <> | Date | Fri, 12 Mar 2010 14:02:57 +0100 | Subject | Re: [PATCH] devtmpfs: support !CONFIG_TMPFS |
| |
On Fri, Mar 12, 2010 at 12:38, Peter Korsgaard <jacmet@sunsite.dk> wrote: >>>>>> "Michael" == Michael Tokarev <mjt@tls.msk.ru> writes: > >> +#ifdef CONFIG_TMPFS > >> return get_sb_single(fs_type, flags, data, shmem_fill_super, mnt); > >> +#else > >> + return get_sb_single(fs_type, flags, data, ramfs_fill_super, mnt); > >> +#endif > >> } > > Michael> May be completely not to the point or even wrong, but I were > Michael> starring at this change for quite some time trying to understand > Michael> what's the difference. Can we do it like this: > > Michael> #ifdef CONFIG_TMPFS > Michael> # define devtmpfs_fill_super shmem_fill_super > Michael> #else > Michael> # define devtmpfs_fill_super ramfs_fill_super > Michael> #endif > Michael> return get_sb_single(fs_type, flags, data, devtmpfs_fill_super, mnt);
> Sure, if people find that cleaner - Kay?
For the style: I would prefer your original version.
For the patch: Acked-by: Kay Sievers <kay.sievers@vrfy.org>
Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |