lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/11] ST SPEAr: Added basic header files for SPEAr3xx machine family
On 3/11/2010 4:03 PM, Russell King - ARM Linux wrote:
> On Wed, Mar 03, 2010 at 10:37:32AM +0530, Viresh KUMAR wrote:
>> diff --git a/arch/arm/mach-spear3xx/include/mach/dma.h b/arch/arm/mach-spear3xx/include/mach/dma.h
>> new file mode 100644
>> index 0000000..9b93bc6
>> --- /dev/null
>> +++ b/arch/arm/mach-spear3xx/include/mach/dma.h
>> @@ -0,0 +1,18 @@
>> +/*
>> + * arch/arm/mach-spear3xx/include/mach/dma.h
>> + *
>> + * Generic DMA support for SPEAr3xx machine family
>> + *
>> + * Copyright (C) 2009 ST Microelectronics
>> + * Viresh Kumar<viresh.kumar@st.com>
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without any
>> + * warranty of any kind, whether express or implied.
>> + */
>> +
>> +#ifndef __ASM_ARCH_DMA_H
>> +#define __ASM_ARCH_DMA_H
>> +
>> +#endif /* __ASM_ARCH_DMA_H */
>> +
>
> You don't need to provide this file if you don't use it.
>

It will be removed.

>> diff --git a/arch/arm/mach-spear3xx/include/mach/vmalloc.h b/arch/arm/mach-spear3xx/include/mach/vmalloc.h
>> new file mode 100644
>> index 0000000..4f236f3
>> --- /dev/null
>> +++ b/arch/arm/mach-spear3xx/include/mach/vmalloc.h
>> @@ -0,0 +1,22 @@
>> +/*
>> + * arch/arm/mach-spear3xx/include/mach/vmalloc.h
>> + *
>> + * Defining Vmalloc area for SPEAr3xx machine family
>> + *
>> + * Copyright (C) 2009 ST Microelectronics
>> + * Viresh Kumar<viresh.kumar@st.com>
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without any
>> + * warranty of any kind, whether express or implied.
>> + */
>> +
>> +#ifndef __ASM_MACH_VMALLOC_H
>> +#define __ASM_MACH_VMALLOC_H
>> +
>> +#include <mach/memory.h>
>> +
>> +#define VMALLOC_SIZE (0x30000000)
>> +#define VMALLOC_END (PAGE_OFFSET + VMALLOC_SIZE)
>
> Don't define it like this - define VMALLOC_END to be the maximum virtual
> address which you can permit the vmalloc area to extend to - which is
> generally the start of your peripheral mappings.
>
> It's rather pointless defining it in terms of PAGE_OFFSET, because this
> can vary, whereas the start of your peripheral mappings tends to be
> fixed.
>

OK. Will be changed.


regards,
viresh kumar



\
 
 \ /
  Last update: 2010-03-12 05:43    [W:0.220 / U:12.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site