lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [tip:sched/core] sched: Remove AFFINE_WAKEUPS feature
    From
    Date
    On Fri, 2010-03-12 at 11:23 +0800, Yong Zhang wrote:
    > On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote:
    > > Commit-ID: beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
    > > Gitweb: http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
    > > Author: Mike Galbraith <efault@gmx.de>
    > > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100
    > > Committer: Ingo Molnar <mingo@elte.hu>
    > > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100
    > >
    > > sched: Remove AFFINE_WAKEUPS feature
    > >
    > > Disabling affine wakeups is too horrible to contemplate. Remove the feature flag.
    >
    > AFFINE_WAKEUPS is still left in sched_feature.h

    Oops, axe got dull. Thanks for checking.

    -Mike

    > From: Yong Zhang <yong.zhang@windriver.com>
    > Date: Fri, 12 Mar 2010 11:14:26 +0800
    > Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature
    >
    > complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
    >
    > Signed-off-by: Yong Zhang <yong.zhang@windriver.com>
    > ---
    > kernel/sched_features.h | 8 --------
    > 1 files changed, 0 insertions(+), 8 deletions(-)
    >
    > diff --git a/kernel/sched_features.h b/kernel/sched_features.h
    > index 83c66e8..2137ac0 100644
    > --- a/kernel/sched_features.h
    > +++ b/kernel/sched_features.h
    > @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1)
    > SCHED_FEAT(WAKEUP_PREEMPT, 1)
    >
    > /*
    > - * Based on load and program behaviour, see if it makes sense to place
    > - * a newly woken task on the same cpu as the task that woke it --
    > - * improve cache locality. Typically used with SYNC wakeups as
    > - * generated by pipes and the like, see also SYNC_WAKEUPS.
    > - */
    > -SCHED_FEAT(AFFINE_WAKEUPS, 1)
    > -
    > -/*
    > * Prefer to schedule the task we woke last (assuming it failed
    > * wakeup-preemption), since its likely going to consume data we
    > * touched, increases cache locality.



    \
     
     \ /
      Last update: 2010-03-12 05:39    [W:0.027 / U:1.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site