lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kobject: Fix kobject_set_name_vargs()
On Thu, Mar 11, 2010 at 09:50:52PM +0100, Eric Dumazet wrote:
> In case of kvasprintf() failure, we can leak old kobject name.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 8115eb1..1247c57 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> return 0;
>
> kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
> - if (!kobj->name)
> + if (!kobj->name) {
> + kobj->name = old_name;
> return -ENOMEM;
> + }

Are you sure? I think we've been over this very thing many times in the
past...

Kay, I can't recall the issue here, can you?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-03-12 05:19    [W:0.026 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site