Messages in this thread | | | Date | Fri, 12 Mar 2010 07:33:18 +0900 | From | Tejun Heo <> | Subject | Re: [RFC] remove implicit slab.h inclusion from percpu.h |
| |
Hello,
On 03/12/2010 02:48 AM, Alexey Dobriyan wrote: >> So, what do you guys think? Probably-the-right-thing-to-do >544 file >> patch or somewhat-ugly-but-let's-worry-about-it-tommorrow two file >> patch? > > You can include slab.h only for UP case. > > Since everyone tests on allmodconfig which has SMP=y, configuration > will be more strict wrt headers, and compile breakages amount > negligible.
But that wouldn't change anything about having to do an oneshot huge change, right? And, if we're gonna do that anyway, I think it would be better to remove the implicit dependency for UP case too so that for example slab.h in this case doesn't have to do ifdef on CONFIG_SMP before using percpu accessors.
Thanks.
-- tejun
| |