lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool
From
Date
On Wed, 2010-03-10 at 14:48 +1100, fthain@telegraphics.com.au wrote:
> On Tue, 9 Mar 2010, Michael Beardsworth wrote:
>
> > - /* If a probe is in progress or we are sleeping, wait for it to complete */
> > + /* If a probe is in progress or we are sleeping, wait until complete */
>
> If you must "fix" what aint broke, please try not to damage it. I'm sorry
> if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is
> misguided.
>
> Maybe I could point out again (I do this periodically) that checkpatch.pl
> is great but code that fails it is NOT always wrong.
>
> "Check patch" is a good idea but "check existing code" is a waste of
> everyone's time.

Amen !

Cheers,
Ben.




\
 
 \ /
  Last update: 2010-03-11 22:47    [W:0.025 / U:6.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site