[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/2] perf record: Don't try to find buildids in a zero sized file
From: Arnaldo Carvalho de Melo <>

Fixing this symptom:

[acme@mica linux-2.6-tip]$ perf record -a -f
Fatal: Permission error - are you root?

Bus error
[acme@mica linux-2.6-tip]$

I.e. if for some reason no data is collected, in this case a non root user
trying to do systemwide profiling, no data will be collected, and then we end
up trying to mmap a zero sized file and access the file header, b00m.

Reported-by: Ingo Molnar <>
Cc: Frédéric Weisbecker <>
Cc: Mike Galbraith <>
Cc: Peter Zijlstra <>
Cc: Paul Mackerras <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/builtin-record.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index f573bbb..3bf1409 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -394,6 +394,9 @@ static int process_buildids(void)
u64 size = lseek(output, 0, SEEK_CUR);

+ if (size == 0)
+ return 0;
session->fd = output;
return __perf_session__process_events(session, post_processing_offset,
size - post_processing_offset,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-03-11 19:57    [W:0.030 / U:9.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site