lkml.org 
[lkml]   [2010]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH 1/1] perf: add support for arch-dependent symbolic event names to "perf stat"
On 3/11/2010 4:46 AM, Ingo Molnar wrote:
[snip]
> If you want extensible events you can already do it by providing an ftrace
> tracepoint event via TRACE_EVENT. They are easy to add and ad-hoc, and are
> supported throughout by perf.

Is TRACE_EVENT an appropriate way to add hardware-specific counter events? I
will look into this. Thanks for the pointer.

>
> That could be librarized further by providing an /eventfs or /proc/events
> interface to enumerate them.

We can enumerate events this way, but there are other aspects to events than
just their names (see below).

>
> Or if you want to extend the perf events namespace ABI you can send patches
> for that as well. (It's not a big issue if a particular event is currently
> only supported on Power for example - as long as you make a good effort naming
> and structuring it in a reasonably generic way.)

I'm not sure how that would work. The issue I am trying to solve here is that
Power arch chips have a large number of very hardware-specific events that are
not generalizable. Many of these events not only have names, but other
user-configurable bits as well that select or narrow the scope of which exact
events are recorded. This issue is dealt with nicely in libpfm4, as it has
mechanisms for parsing event names and attributes (aka modifiers or unit masks),
and then produces a usable config field for the perf_events_attr struct.

Should I take it from the above that you are completely against the idea of
using an external library for hardware-specific event and attribute naming?

--
Regards,

- Corey



\
 
 \ /
  Last update: 2010-03-11 19:49    [from the cache]
©2003-2011 Jasper Spaans